Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clarification of containerz behaviour after reboot/failover #3472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alshabib
Copy link
Contributor

No description provided.

@alshabib alshabib requested a review from a team as a code owner September 27, 2024 17:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11075248551

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11069560355: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@@ -4,6 +4,13 @@

Verify the correct behaviour of `gNOI.Containerz` when operating containers.

### Restart Behaviour
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest rephrasing this as a test procedure and moving into it's own subtest (for example, as CNTR-1.5 below)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this seems a good way to cover it. We probably want a test that verifies this. We can do a reboot + a triggered switchover (using gNOI) to validate these things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants